I don't believe the queen has broken any laws. I'm not really sure that is the point though is it. If lawmakers in this county are quite happy to hold assets in dodgy tax-havens then why should members of the public pay their 'fair share'?
If HMRC could seriously go after companies and individuals that use tax-havens (with the help of the government of the day) then the UK public finances would be in much better shape. Sadly there is no political will, why would the Tories want to annoy it's best-paying donors and friends in the media.